Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing field_name in ValueError #792

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chasleslr
Copy link

I encountered this error a few times and noticed the variable name was missing. Without this commit, the error currently reads:

Field {} is not "nullable", but got passes a None value

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Charles Lariviere seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@selitvin
Copy link
Collaborator

selitvin commented Apr 4, 2023

Thanks for the fix! So we can land your change, can you please accept the CLA?

@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0b0775a) 86.24% compared to head (b808fc1) 86.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #792   +/-   ##
=======================================
  Coverage   86.24%   86.24%           
=======================================
  Files          84       84           
  Lines        5090     5090           
  Branches      790      790           
=======================================
  Hits         4390     4390           
  Misses        560      560           
  Partials      140      140           
Impacted Files Coverage Δ
petastorm/unischema.py 93.30% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants