Skip to content

Commit

Permalink
Fix tests now that Buildkite is running (#12)
Browse files Browse the repository at this point in the history
  • Loading branch information
KevinGrandon authored Aug 21, 2018
1 parent 1e201a1 commit 032154e
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 9 deletions.
6 changes: 3 additions & 3 deletions .buildkite/pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ steps:
- name: ':docker: :package:'
plugins:
'docker-compose#v1.7.0':
build: probot-app-label-release-pr
build: probot-app-pr-label
image-repository: 027047743804.dkr.ecr.us-east-2.amazonaws.com/uber
agents:
queue: builders
Expand All @@ -11,13 +11,13 @@ steps:
command: yarn lint
plugins:
'docker-compose#v1.7.0':
run: probot-app-label-release-pr
run: probot-app-pr-label
agents:
queue: workers
- name: ':jest:'
command: yarn jest
plugins:
'docker-compose#v1.7.0':
run: probot-app-label-release-pr
run: probot-app-pr-label
agents:
queue: workers
5 changes: 0 additions & 5 deletions __tests__/index.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ describe('probot-app-pr-label', () => {
robot.load(app);
github = {
issues: {
createComment: jest.fn(),
getComments: jest
.fn()
.mockReturnValue(
Expand Down Expand Up @@ -50,10 +49,6 @@ describe('probot-app-pr-label', () => {
expect(statusCalls.length).toBe(2);
expect(statusCalls[0][0].state).toBe('pending');
expect(statusCalls[1][0].state).toBe('failure');

// Should also post a comment
const createCommentCalls = github.issues.createComment.mock.calls;
expect(createCommentCalls.length).toBe(1);
});

it('set status to success if at least one required label in payload', async () => {
Expand Down
1 change: 0 additions & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ module.exports = robot => {
robot.on('pull_request.labeled', check);

async function check(context) {
const {github} = context;
const pr = context.payload.pull_request;

const requiredLabels = (await context.config('required-labels.yml', {
Expand Down

0 comments on commit 032154e

Please sign in to comment.