-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade go version to 1.21 in go.mod #1425
base: master
Are you sure you want to change the base?
Conversation
Hey @arukiidou - my understanding is that the go line in a library's go.mod file now sets a requirement for all consumers of the library, so I actually think we may want to be more conservative when it comes to updating it so as to not require all consumers to upgrade, unless there's a very good reason. But I'm open to other thoughts! |
Yes, it will need to upgrade most of go.mods to pass the test. Why upgrades?
You make a good point , could postpone this for several months. |
Hey @arukiidou -
If it's ok with you, I think we should probably wait on this. |
Ok, I understood that this is still early. Please let me know when the time comes. |
cd0bcee
to
436c470
Compare
Signed-off-by: junya koyama <[email protected]>
Signed-off-by: junya koyama <[email protected]>
Signed-off-by: junya koyama <[email protected]>
436c470
to
064241d
Compare
@JacobOaks |
I upgraded go version to 1.21 in go.mod.
copy of #1181