zapslog: Handler options changes via WithOptions #1381
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
WithOptions
method toHandler
to allow option changes after initial creation.This would be useful if wrapping a logger and needing to preserve attributes but also have correct source/stacktrace details.
This is similar to the options functionality in the logger:
zap/logger.go
Lines 58 to 79 in c17272e
zap/logger.go
Lines 166 to 174 in c17272e