Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Metrics to Dosa Library #455

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Metrics to Dosa Library #455

wants to merge 1 commit into from

Conversation

awaniim
Copy link
Collaborator

@awaniim awaniim commented Sep 14, 2021

No description provided.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@@ -79,7 +79,7 @@ func ExampleNewClient() {
conn := devnull.NewConnector()

// create the client using the registrar and connector
client := dosaRenamed.NewClient(reg, conn)
client := dosaRenamed.NewClient(reg, conn, )

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo?

Copy link

@patelpiyush patelpiyush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit in test params

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants