Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a 'defunct' tag for Index definitions #387

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

skywhat
Copy link
Contributor

@skywhat skywhat commented Jun 21, 2019

Cassandra doesn’t support changing columns of the materialized view. Therefore It introduces the concern that how to handle the existing index table since the goal of the feature is to reduce the large partition.
The current solution is to educate users to mark their old index table as defunct and then create a new index table with limited columns.
The next time users use range query, the gateway would skip the lookup in defunct index table.

@skywhat skywhat requested a review from phliar June 21, 2019 01:26
@phliar
Copy link
Contributor

phliar commented Jun 21, 2019

The title can be shorted to Add a 'defunct' tag for Index definitions

@skywhat skywhat changed the title Add a 'defunct' tag for Index definitions that define the index is defunct or not Add a 'defunct' tag for Index definitions Jun 21, 2019
@@ -51,6 +52,8 @@ var (

columnsPattern = regexp.MustCompile(`columns\s*=\s*\(([^\(\)]+)\)`)

defunctPattern = regexp.MustCompile(`defunct\s*=\s*(true|false)`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it have to be defunct=true? I'd like to be able to simply say something like

   Index `dosa:"key=(foo,bar),defunct"`

@CLAassistant
Copy link

CLAassistant commented Jun 13, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Gang Zhang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants