Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YARPC Connector: Add client side timestamp with microsecond monotonicity #355

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

YARPC Connector: Add client side timestamp with microsecond monotonicity #355

wants to merge 1 commit into from

Conversation

jquirke
Copy link

@jquirke jquirke commented Aug 1, 2018

Adds client side timestamps to the YARPC connector to ensure writes are observed at the destination in the correct order.

@CLAassistant
Copy link

CLAassistant commented Aug 1, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jquirke jquirke changed the title YARPC: Add client side timestamp with microsecond monotonicity YARPC Connector: Add client side timestamp with microsecond monotonicity Aug 1, 2018
dgladkov
dgladkov approved these changes Aug 6, 2018
View reviewed changes
Copy link

@dgladkov dgladkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation LGTM. However, I think ClientTimestamp option should be set to true by default for YARPC connector as relying on server timestamps can lead to data loss.

phliar
phliar suggested changes Aug 8, 2018
View reviewed changes
Copy link
Contributor

@phliar phliar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not going to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phliar phliar phliar requested changes

@dgladkov dgladkov dgladkov approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jquirke @CLAassistant @dgladkov @phliar