index columns zero value is []string(nil) but not []string{} (#383)

* columns zero value is []string(nil) but not []string{} * fix entity_parse unit test
uber-go · Jun 10, 2019 · e8a173b · e8a173b
1 parent 9b23cfc
commit e8a173b
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/entity.go b/entity.go
@@ -172,7 +172,7 @@ type IndexDefinition struct {
 
 // Clone returns a deep copy of IndexDefinition
 func (id *IndexDefinition) Clone() *IndexDefinition {
-	columns := make([]string, len(id.Columns))
+	var columns []string
 	copy(columns, id.Columns)
 	return &IndexDefinition{
 		Key:     id.Key.Clone(),

diff --git a/entity_test.go b/entity_test.go
@@ -358,14 +358,12 @@ func getValidEntityDefinition() *dosa.EntityDefinition {
 						},
 					},
 				},
-				Columns: []string{},
 			},
 
 			"index2": {
 				Key: &dosa.PrimaryKey{
 					PartitionKeys: []string{"bar"},
 				},
-				Columns: []string{},
 			},
 		},
 		Columns: []*dosa.ColumnDefinition{