Skip to content

Commit

Permalink
help messages should all start with uppercase (#347)
Browse files Browse the repository at this point in the history
  • Loading branch information
MaxJTRice authored Jul 13, 2018
1 parent e13b967 commit aef8351
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
- Add functionality to not invalidate cache when upsert (#341)
- Add query (read/range) support to CLI (#342)
- Fix CLI help message (#346)
- CLI help messages should all start with an uppercase character (#347)

## v3.0.1 (2018-06-07)
- Fixed version const
Expand Down
14 changes: 7 additions & 7 deletions cmd/dosa/query.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ func newQueryObj(fieldName, op, valueStr string) *queryObj {

// QueryOptions contains configuration for query command flags
type QueryOptions struct {
Fields string `short:"f" long:"fields" description:"fields of results to return, separated by comma."`
Fields string `short:"f" long:"fields" description:"Fields of results to return, separated by comma."`
}

// QueryCmd is a placeholder for all query commands
Expand All @@ -54,7 +54,7 @@ type QueryCmd struct {
Scope scopeFlag `short:"s" long:"scope" description:"Storage scope for the given operation." required:"true"`
NamePrefix string `short:"n" long:"namePrefix" description:"Name prefix for schema types."`
Prefix string `short:"p" long:"prefix" description:"Name prefix for schema types." hidden:"true"`
Path string `long:"path" description:"path to source." required:"true"`
Path string `long:"path" description:"Path to source." required:"true"`
provideClient queryClientProvider
}

Expand Down Expand Up @@ -108,8 +108,8 @@ func (c *QueryCmd) doQueryOp(f func(ShellQueryClient, context.Context, []*queryO
type QueryRead struct {
*QueryCmd
Args struct {
EntityName string `positional-arg-name:"entity" description:"entity name"`
Queries []string `positional-arg-name:"queries" description:"queries should be in the form field:operator:value, supported operator: eq"`
EntityName string `positional-arg-name:"entity" description:"Entity name."`
Queries []string `positional-arg-name:"queries" description:"Queries should be in the form field:operator:value, supported operator: eq."`
} `positional-args:"yes"`
}

Expand All @@ -129,10 +129,10 @@ func (c *QueryRead) Execute(args []string) error {
// QueryRange holds the options for 'query range'
type QueryRange struct {
*QueryCmd
Limit int `short:"l" long:"limit" default:"100" description:"max number of results to return"`
Limit int `short:"l" long:"limit" default:"100" description:"Max number of results to return."`
Args struct {
EntityName string `positional-arg-name:"entity" description:"entity name"`
Queries []string `positional-arg-name:"queries" description:"queries should be in the form field:operator:value, supported operators: eq,lt,le,gt,ge"`
EntityName string `positional-arg-name:"entity" description:"Entity name."`
Queries []string `positional-arg-name:"queries" description:"Queries should be in the form field:operator:value, supported operators: eq,lt,le,gt,ge."`
} `positional-args:"yes"`
}

Expand Down

0 comments on commit aef8351

Please sign in to comment.