Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV-191: Entrepreneurship and Management minor #506

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

Byuljapcho
Copy link
Collaborator

Description:
Added the Entrepreneurship and Management minor

Implementation:
Wrote the minor named minorEntrMgmt in majors.tsx

Testing: N/A

@vercel
Copy link

vercel bot commented May 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ucredit-distributions-demo ✅ Ready (Inspect) Visit Preview May 11, 2023 5:16am
ucredit-frontend-typescript ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2023 5:16am
ucredit-frontend-typescript-local ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2023 5:16am

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

'<br /> <i>OR</i> <br />' +
'EN.661.380 Decision Analytics <br/>',
criteria:
'AS.230.205[C]^OR^AS.280.345[C]^OR^AS.280.345[C]^OR^EN.553.111[C]^OR^EN.553.112[C]^OR^EN.661.380[C]',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

herro miseok :3 is AS.280.345 supposed to be here twice?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prolly not, but it doesn't affect the logic kewk

description:
'Students must complete three fundamental courses in entrepreneurship and management.',
criteria:
'EN.660.105[C]^OR^EN.660.250[C]^OR^EN.660.203[C]^OR^EN.661.110[C]^OR^EN.661.250[C]',
Copy link
Collaborator

@josephined21 josephined21 May 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oke disclaimer i know nothing abt writing majors so i am prob completely wrong but i thought it should be like (105 or 250) and 203 and (110 or 250)? why so many or's? :0

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Josephine's right, this criteria is fine but the fine distributions below should be three categories:

Screenshot 2023-09-22 at 3 34 21 PM

'Courses may be chosen from the list below. Students can choose 1 course from the Marketing' +
' & Communications electives listed in a separate table below.',
criteria:
'AS.180.263[C]^OR^EN.570.334[C]^OR^EN.661.301[C]^OR^EN.661.315[C]^EN.661.317[C]^' +
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should 300, 303, 308, 310, 329, etc etc be included here as well?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah good catch

Copy link
Collaborator

@mpark63 mpark63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

'<br /> <i>OR</i> <br />' +
'EN.661.380 Decision Analytics <br/>',
criteria:
'AS.230.205[C]^OR^AS.280.345[C]^OR^AS.280.345[C]^OR^EN.553.111[C]^OR^EN.553.112[C]^OR^EN.661.380[C]',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prolly not, but it doesn't affect the logic kewk

description:
'Students must complete three fundamental courses in entrepreneurship and management.',
criteria:
'EN.660.105[C]^OR^EN.660.250[C]^OR^EN.660.203[C]^OR^EN.661.110[C]^OR^EN.661.250[C]',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Josephine's right, this criteria is fine but the fine distributions below should be three categories:

Screenshot 2023-09-22 at 3 34 21 PM

'Courses may be chosen from the list below. Students can choose 1 course from the Marketing' +
' & Communications electives listed in a separate table below.',
criteria:
'AS.180.263[C]^OR^EN.570.334[C]^OR^EN.661.301[C]^OR^EN.661.315[C]^EN.661.317[C]^' +
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah good catch

Comment on lines +5186 to +5187
'AS.230.205[C]^OR^AS.280.345[C]^OR^AS.280.345[C]^OR^EN.553.111[C]^OR^EN.553.112[C]^OR^EN.661.380[C]^OR^' +
'EN.553.211[C]^OR^EN.553.310[C]^OR^EN.553.311[C]^OR^EN.553.430[C]^OR^EN.560.240[C]',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +5324 to +5340
fine_requirements: [
{
required_credits: 3,
description:
'<b>EN.660.410</b> <br />Computer Science Innovation and Entrepreneurship**',
criteria: 'EN.660.410[C]',
},
{
required_credits: 3,
description:
'<b>EN.660.411</b> <br />Corporate Strategy and Business Failure**',
criteria: 'EN.660.411[C]',
},
{
required_credits: 3,
description: '<b>EN.660.419</b> <br />Strategy Consulting**',
criteria: 'EN.660.419[C]',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These shouldn't be fine requirements because you only need one course out of all of these

@mpark63 mpark63 changed the title Dev 191 DEV-191: Entrepreneurship and Management minor Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants