Update Twilio Conversations & Paste to latest #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 21, 2022 12:59
…ste and dependencies, updated tests to pass
…ste and dependencies, updated tests to pass
added 5 commits
October 25, 2022 10:15
…ste and dependencies, updated tests to pass
|
@nayanadasgupta I also merged the latest changes from main fork, it took a couple of commits because I missed to resolve conflicts in a file. Let me know if they look ok because prev file's format on some do not match the prettier policy even before my commits. |
Comment on lines
+21
to
+40
| export interface ParticipantResponse { | ||
| account_sid: string; | ||
| chat_service_sid: string; | ||
| conversation_sid: string; | ||
| role_sid: string; | ||
| sid: string; | ||
| attributes: string; | ||
| date_created: string; | ||
| date_updated: string; | ||
| identity: string; | ||
| messaging_binding: { | ||
| type: "chat" | "sms" | "whatsapp" | "email"; | ||
| address: string; | ||
| proxy_address: string; | ||
| } | null; | ||
| url: string; | ||
| links: { | ||
| conversation: string; | ||
| }; | ||
| } |
There was a problem hiding this comment.
Wondering if it's necessary to define this purely for the mock file's benefit. Was this because the new Conversations version required it?
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is for updating the Twilio Conversations library to the latest stable one and Twilio Paste (new design system) to latest version for improved stability.
Also, some tests have been updated to account for Pastes current state regarding components. This includes a custom query for locking for the special data-paste-element attribute used along Paste's components.
Contributing to Twilio