Add lower dim tests #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 1, 2024 14:18
| ): | ||
| with computation(PARALLEL): | ||
| with interval(0, 1): | ||
| out_field[0, 0, 0] = in_field[1] |
There was a problem hiding this comment.
This truly should fail in my opinion. The default behavior that allows you to not index data dimensions is too magical. We have something showing in GEOS-ESM/NDSL#43 that is around that behavior
| @@ -167,9 +167,6 @@ def visit_TemporaryDecl( | |||
|
|
|||
| VarKOffset = as_fmt("lk + {k}") | |||
|
|
|||
| def visit_CallbackCall(self, node: npir.CallbackCall) -> Union[str, Collection[str]]: | |||
There was a problem hiding this comment.
Remove because that's the default behavior? Or am I missing something
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After realizing that there was an issue with lower-dimensional fields in the debug-backend, this PR adds a test to check correctness.
Requirements
Before submitting this PR, please make sure: