Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add Email Verification for non-Microsoft/Google Emails #9288

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

samyakpiya
Copy link
Contributor

@samyakpiya samyakpiya commented Dec 31, 2024

Closes #8240

WIP - TODOs:

Sign Up Process

  • Introduce server-level environment variable IS_EMAIL_VERIFICATION_REQUIRED (defaults to false)
  • Ensure users joining an existing workspace through an invite are not required to validate their email
  • Generate an email verification token
  • Store the token in appToken
  • Send email containing the verification link
    • Create new email template for email verification
  • Create a frontend page to handle verification requests

Sign In Process

  • After verifying user credentials, check if user's email is verified and prompt to to verify
  • Show an option to resend the verification email

Database

  • Rename the emailVerified colum on user to to isEmailVerified for consistency

Deployment

  • Run a script/sql query to set isEmailVerified to true for all users with a Google/Microsoft email and all users that show an indication of a valid subscription (e.g. linked credit card)

Copy link

github-actions bot commented Dec 31, 2024

Warnings
⚠️ Changes were made to the environment variables, but not to the documentation - Please review your changes and check if a change needs to be documented!

Generated by 🚫 dangerJS against 71b2f50

- Add token generation for email verification
- Store verification tokens in appToken
- Implement verification email sending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Email verification
2 participants