fix: Resolve "Can't delete an account" issue (#9232) #9238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR fixes a context binding issue in the user deletion process where this was being lost during Array.map() execution, causing dataSourceService to be undefined.
- Fixed
deleteUserFromWorkspacecontext inpackages/twenty-server/src/engine/core-modules/user/services/user.service.tsby bindingthisto preserve service access - Added error handling for workspace member deletion when user is the last member
- Ensures proper cleanup of workspace data when deleting the last user
- Maintains workspace event emission for member deletion tracking
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Weiko
reviewed
Jan 2, 2025
| if (workspaceMembers.length === 1) { | ||
| await this.workspaceService.deleteWorkspace(workspaceId); | ||
| } | ||
|
|
||
| const objectMetadata = await this.objectMetadataRepository.findOneOrFail({ | ||
| where: { | ||
| nameSingular: 'workspaceMember', |
There was a problem hiding this comment.
Just realised this should be filtered by workspaceId to be safe. Although it's only used for the emit event below. I'll update that in a future PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request addresses the issue described in #9232, where attempting to delete a user account results in a
TypeError: Cannot read properties of undefined (reading 'dataSourceService').Changes Made
thiscontext issue in thedeleteUserFromWorkspacemethod by ensuring it is correctly bound.deleteUsermethod to use a bound function when callingdeleteUserFromWorkspace.Linked Issue
This pull request fixes #9232.
Additional Notes