Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make workflow step name editable #8677

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Make workflow step name editable #8677

merged 4 commits into from
Nov 22, 2024
+218 −158

Conversation

thomtrp
Copy link
Contributor

@thomtrp thomtrp commented Nov 22, 2024 •
edited
Loading

  • Use TextInput in header title
  • add onTitleChange prop
  • rename field name instead of label

To fix :

  • padding right on title comes from current TextInput component. It needs to be refactored
Enregistrement.de.l.ecran.2024-11-22.a.11.40.30.mov

@thomtrp thomtrp changed the title Tt make step title editable Make workflow step name editable Nov 22, 2024
@martmull
Copy link
Contributor

Functional comments:

  • variable dropdown item should match the custom name
    image

@thomtrp
Copy link
Contributor Author

thomtrp commented Nov 22, 2024

Good catch @martmull 💪

Updated
Capture d’écran 2024-11-22 à 14 51 14

@martmull martmull enabled auto-merge (squash) November 22, 2024 14:38
@martmull martmull enabled auto-merge (squash) November 22, 2024 15:23
@martmull martmull merged commit 5ec6cb0 into main Nov 22, 2024
19 checks passed
@martmull martmull deleted the tt-make-step-title-editable branch November 22, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Devessier Devessier Devessier left review comments

@martmull martmull martmull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomtrp @martmull @Devessier