Fix array and links display #8671
Merged
+25
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR simplifies and standardizes the display of arrays and links across the application by removing unnecessary styling complexity and focus state handling.
- Replaced custom styled tags with Chip components in
packages/twenty-front/src/modules/ui/field/display/components/ArrayDisplay.tsx - Removed focus state handling from both ArrayFieldDisplay and LinksFieldDisplay components
- Improved URL type checking regex patterns in
packages/twenty-front/src/utils/checkUrlType.tsfor better LinkedIn and Twitter URL handling - Standardized link display using ExpandableList with RoundedLink and SocialLink components
- Removed unused
isInputDisplayprop from ArrayFieldMenuItem component
6 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-front/src/modules/ui/field/display/components/ArrayDisplay.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
+22
to
24
| {value?.map((item) => ( | ||
| <Chip variant={ChipVariant.Highlighted} label={item} /> | ||
| ))} |
There was a problem hiding this comment.
logic: Missing key prop for mapped elements
| return isFocused ? ( | ||
| <ExpandableList isChipCountDisplayed> | ||
| return ( | ||
| <ExpandableList> | ||
| {links.map(({ url, label, type }, index) => |
There was a problem hiding this comment.
style: Using array index as key may cause issues with React reconciliation if links are reordered
| url, | ||
| ) | ||
| ) { | ||
| if (/^(https?:\/\/)?(www\.)?linkedin\.com(\/[\w\-\/?#:.%=&]*)?$/.test(url)) { |
There was a problem hiding this comment.
logic: The new regex pattern allows invalid LinkedIn URLs that end with .linkedin.com (e.g. fake.linkedin.com)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After