feat(): add IS_MULTIWORKSPACE_ENABLE flag #8656
Draft
+42
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced the 'IS_SIGN_UP_DISABLED' flag with 'IS_MULTIWORKSPACE_ENABLED' to control workspace creation. This change allows for conditional workspace setup based on the new environment variable. Also updated related service, resolver, and entity files.
Updated the IS_MULTIWORKSPACE_ENABLED setting description to indicate support for multiple workspaces. This update clarifies that a web server capable of managing subdomain wildcards is required.
Updated the .env.example file to replace the IS_SIGN_UP_DISABLED variable with IS_MULTIWORKSPACE_ENABLED. Removed the IS_SIGN_UP_DISABLED property from environment-variables.ts as it is no longer needed.
…nabled Removed isSignUpDisabledState and associated references, and replaced them with isMultiworkspaceEnabledState. Updated GraphQL queries and related components to reflect this change, and ensured multi-workspace functionality is enabled where applicable.
Corrected the casing of the `isMultiWorkspaceEnabled` variable in the NavigationDrawerHeader component. This ensures consistent naming conventions and avoids potential bugs related to variable misnaming.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR introduces multi-workspace functionality by replacing the sign-up disabled flag with a multi-workspace enabled flag across the application.
- Inconsistent casing in state key naming (
isMultiworkspaceEnabledvsisMultiWorkspaceEnabled) in/packages/twenty-front/src/modules/client-config/states/isMultiWorkspaceEnabledState.ts - Default value mismatch between frontend (true) and server (false) for
isMultiWorkspaceEnabledcould cause inconsistent behavior - Removal of
signUpDisabledstate without clear alternative mechanism needs review for impact on user registration flows - Added note in documentation about wildcard subdomain requirement for multi-workspace feature
- Server-side logic in
sign-in-up.service.tsnow blocks creation of additional workspaces when multi-workspace is disabled
12 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-front/src/modules/client-config/components/ClientConfigProviderEffect.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/client-config/states/isMultiWorkspaceEnabledState.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/client-config/states/isMultiWorkspaceEnabledState.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/auth/services/sign-in-up.service.ts
Show resolved
Hide resolved
martmull
reviewed
Nov 21, 2024
packages/twenty-server/src/engine/core-modules/environment/environment-variables.ts
Show resolved
Hide resolved
Corrected the typo from isMultiworkspaceEnabled to isMultiWorkspaceEnabled. This change affects multiple files to ensure consistency across the codebase, including GraphQL queries, state management, and server configurations.
|
|
| AuthExceptionCode.FORBIDDEN_EXCEPTION, | ||
| ); | ||
| if (!this.environmentService.get('IS_MULTIWORKSPACE_ENABLED')) { | ||
| const numberOfWorkspaces = await this.workspaceRepository.count(); |
charlesBochet
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for multi-workspace feature and adjust configurations and states accordingly.