fix: navigation drawer clip while making folder in favorites #8619
+11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Fixed navigation drawer overflow issue when creating favorite folders by adjusting input and icon padding in NavigationDrawerInput component.
- Removed default padding from
StyledTextInputin/packages/twenty-front/src/modules/ui/navigation/navigation-drawer/components/NavigationDrawerInput.tsxto prevent overflow - Added
paddingRight: theme.spacing(2)to Icon component to maintain consistent spacing - Ensures input text stays within drawer boundaries while preserving visual alignment
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
… if collapsed on adding folder from picker
ehconitin
reviewed
Nov 22, 2024
| @@ -27,6 +31,7 @@ export const FavoriteFolderPickerFooter = () => { | |||
| <MenuItem | |||
| className="add-folder" | |||
| onClick={() => { | |||
| setIsNavigationDrawerExpanded(true); | |||
There was a problem hiding this comment.
@martmull How about this? I missed this earlier and added it here -- not related to the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8606
Reason for the issue:
The issue was caused by the padding in
TEXT_INPUT_STYLE, which was being applied to theStyledTextInputcomponent used inNavigationDrawerInput.Changes
StyledTextInputwith a value of 0.Icon. This ensures consistent spacing between the Icon and the input value, maintaining the same visual alignment as before.Screencast.from.2024-11-20.23-32-24.webm