Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(workspaces): Rename SEED_TWENTY_WORKSPACE_ID to SEED_ACME_WO… #8611

Merged

Conversation

AMoreaux
Copy link
Contributor

@AMoreaux AMoreaux commented Nov 20, 2024

…RKSPACE_ID

The Pull Request modifies seed data by replacing SEED_TWENTY_WORKSPACE_ID with SEED_ACME_WORKSPACE_ID across several files.

  • Updated SEED_TWENTY_WORKSPACE_ID to SEED_ACME_WORKSPACE_ID.
  • Modified relevant import paths and seeds involving workspace data.
  • Changes affect seeding processes for workspace members, user workspaces, and general workspace details.

…RKSPACE_ID

Updated workspace ID and corresponding details to SEED_ACME_WORKSPACE_ID across multiple files. This change reflects the new naming convention and ensures consistency within our seed data.
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR renames the SEED_TWENTY_WORKSPACE_ID constant to SEED_ACME_WORKSPACE_ID across multiple files, updating related workspace details from 'Twenty' to 'Acme' for consistency in seed data.

  • Updated workspace display name and domain in /packages/twenty-server/src/database/typeorm-seeds/core/workspaces.ts from 'Twenty' to 'Acme'
  • Logo URL in workspaces.ts still references 'twenty-logo.png' despite workspace rename
  • Maintains existing member assignments where TIM is in both workspaces while JONY/PHIL remain Apple-only
  • Preserves original workspace ID value despite the constant rename

4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

@charlesBochet
Copy link
Member

@lucasbordeau is completely re-writing the seeds, we can ask him to take this change into account.
Btw, I'm not a fan of ACME, I had to google it to understand it was a fictional company, why not something more explicit: FAKE_COMPANY or something like this?

@FelixMalfait
Copy link
Member

@charlesBochet this is the most common fake company name / industry standard used in most codebase imo. We've considered introducing a second company like "Netflix" but then having Tim Apple in both didn't make much sense. I don't think it's a big deal and we should merge like this imo (+ I don't like 'Fake company')

@FelixMalfait
Copy link
Member

@FelixMalfait FelixMalfait merged commit 4d8445a into twentyhq:main Nov 22, 2024
17 checks passed
Copy link

Thanks @AMoreaux for your contribution!
This marks your 8th PR on the repo. You're top 5% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants