Replace react-router-dom Link with div for inner clickables #8323
+19
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8298
Origin of the issue
When there is a clickable inside the table row, it uses the
Link
component fromreact-router-dom
. But at the same time, table row is also usingLink
component for navigation when it's clickable. SinceLink
component usesa
tag under the hood, it results in a nesteda
tag warning in the dev console.People
row is an example that causes the issues underCompanies
data model.Changes made
Replaced the inner
Link
component withdiv
tag that triggers navigation ononClick
event. Stopped the event from bubbling up to the table row and prevented the default navigation behavior of the table row as well.