Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent isDisabled prop from passing to DOM in Settings/Security Link #8317

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

harshrajeevsingh
Copy link
Contributor

Fixes: #8297

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Fixed React warning in Settings/Security tab by preventing invalid DOM attribute propagation.

  • Added shouldForwardProp option to StyledLink in /packages/twenty-front/src/modules/settings/security/components/SettingsSSOIdentitiesProvidersListCard.tsx to filter out isDisabled prop
  • Maintains existing disabled functionality through pointer-events CSS property

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in devtools while checking Security tab
1 participant