Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Use <article> element for example cards #40965

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Docs: Use <article> element for example cards #40965

wants to merge 1 commit into from

Conversation

coliff
Copy link
Contributor

@coliff coliff commented Oct 22, 2024 •
edited
Loading

Description & Motivation & Context

This makes semantic sense.

REF: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/article

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@coliff coliff changed the title Docs; Use <article> element for example cards Docs: Use <article> element for example cards Oct 22, 2024
@julien-deramond julien-deramond requested a review from a team October 22, 2024 12:25
louismaximepiton
louismaximepiton approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@louismaximepiton louismaximepiton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!
On my side, I'm fine with it, any thoughts @patrickhlauke ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louismaximepiton louismaximepiton louismaximepiton approved these changes

@patrickhlauke patrickhlauke Awaiting requested review from patrickhlauke

Assignees
No one assigned
Labels
accessibility docs enhancement v5
Projects
v5.3.4
Status: Needs review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coliff @louismaximepiton @julien-deramond