Buttons: Check data exists before toggle #40945
Open
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-deramond
requested changes
Oct 14, 2024
There was a problem hiding this comment.
Thanks for the PR, @MohamadSalman11! Could you add some unit tests to the JS modifications? Ideally, these tests would demonstrate the previous configuration where the issue occurred and confirm that the updated code resolves it.
julien-deramond
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before toggling, it’s a good practice to check if the data exists because the closest method might not find the element in some weird scenarios. This helps prevent errors.
Motivation & Context
Type of changes
Checklist
npm run lint)Live previews
Related issues