Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from ESLint & Prettier to Biome #690

Merged
merged 11 commits into from
May 28, 2024
Merged

Switch from ESLint & Prettier to Biome #690

merged 11 commits into from
May 28, 2024

Conversation

Acconut
Copy link
Member

@Acconut Acconut commented May 27, 2024

This PR replaces ESLint and Prettier with Biome, resulting in a less complex configuration file for linting and formatting. It is based on Biome's recommended rules plus some rules that were suggested by Biome's migration script. Some changes to our source code was necessary to please the new tool, but I think they are fair overall.

@Acconut Acconut requested a review from Murderlon May 27, 2024 21:10
biome.json Outdated Show resolved Hide resolved
biome.json Outdated Show resolved Hide resolved
lib/index.test-d.ts Outdated Show resolved Hide resolved
Copy link
Member

@kvz kvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking sensible! Just a few nits/questions

@Murderlon
Copy link
Member

LGTM

@Acconut Acconut marked this pull request as ready for review May 28, 2024 12:25
@Acconut Acconut merged commit b147b53 into main May 28, 2024
8 of 10 checks passed
@Acconut Acconut deleted the biome branch May 28, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants