Feat/job application show

README.md

@@ -289,6 +289,11 @@ Unsuccessful Response(job application does not exist OR belongs to another user)
 {:message=>"Job application not found", :status=>404}
 ```
 
+Unsuccessful Response(missing job application ID param):
+```
+{:message=>"Job application ID is missing", :status=>400}
+```
+
 ### Companies
 
 Get login credentials

app/controllers/api/v1/job_applications_controller.rb

@@ -12,6 +12,10 @@ def create
   end
 
   def show
+    if params[:id].blank?
+      render json: ErrorSerializer.format_error(ErrorMessage.new("Job application ID is missing", 400)), status: :bad_request
+      return
+    end
     user = User.find(params[:user_id])
     job_application = JobApplication.find_by(id: params[:id])
 

config/routes.rb

@@ -11,6 +11,7 @@
     namespace :v1 do
       resources :users, only: [:create, :index, :show, :update] do
         resources :job_applications, only: [:create, :show]
+        get '/job_applications(/:id)', to: 'job_applications#show'
       end
       resources :companies, only: [:create, :index]
 

spec/requests/api/v1/job_applications/job_application_show_spec.rb

@@ -109,6 +109,18 @@
         expect(json[:message]).to eq("Job application not found")
         expect(json[:status]).to eq(404)
       end
+
+      it "returns error serializer if no params are passed in URL for job application id" do
+        get "/api/v1/users/#{@user.id}/job_applications/"
+
+        expect(response).to_not be_successful
+        expect(response.status).to eq(400)
+
+        json = JSON.parse(response.body, symbolize_names: true)
+
+        expect(json[:message]).to eq("Job application ID is missing")
+        expect(json[:status]).to eq(400)
+      end
     end
   end
 end