-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bmcd
package
#116
Merged
Merged
Add bmcd
package
#116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, script S95hello.sh would: 1. mount sdcard 2. call scripts 3. print ASCII art 4. launch bmc daemon However, the new version of BMC daemon (aptly named bmcd) which warrants its own proper startup script, needs to launch after steps 1-2, but prior to ASCII-art being printed. Split steps 1-2 and 3 into their own scripts, with priorities 93 and 99 respectively, and remove redundant .sh suffix. The new daemon will start at priority 94. User-defined scripts can run on priorities 95-98. The ASCII-art could be moved to /etc/issue by using a post-build.sh script, however this would cause the art to be printed several times on boot and login.
When start-stop-daemon(8) daemonizes a process, it closes stdout and stderr (which is technically the whole point of daemons) but that leaves us and users with no way to see bmcd's output. Since it is the most important daemon on the system, enable seeing its output and to do so, upgrade start-stop-daemon from lean busybox version to debian's.
svenrademakers
previously approved these changes
Aug 21, 2023
svenrademakers
previously approved these changes
Aug 23, 2023
svenrademakers
force-pushed
the
feature/hello_bmcd
branch
from
August 24, 2023 09:12
76fb15a
to
dc28876
Compare
svenrademakers
force-pushed
the
feature/hello_bmcd
branch
from
August 28, 2023 08:33
dc28876
to
394d97d
Compare
svenrademakers
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't have the chance to test-drive this. I trust you it's working accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.