Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bmcd package #116

Merged
merged 5 commits into from
Sep 5, 2023
Merged

Add bmcd package #116

merged 5 commits into from
Sep 5, 2023

Conversation

ruslashev
Copy link
Contributor

No description provided.

Prior to this change, script S95hello.sh would:

1. mount sdcard
2. call scripts
3. print ASCII art
4. launch bmc daemon

However, the new version of BMC daemon (aptly named bmcd) which warrants
its own proper startup script, needs to launch after steps 1-2, but
prior to ASCII-art being printed.

Split steps 1-2 and 3 into their own scripts, with priorities 93 and 99
respectively, and remove redundant .sh suffix. The new daemon will start
at priority 94. User-defined scripts can run on priorities 95-98.

The ASCII-art could be moved to /etc/issue by using a post-build.sh
script, however this would cause the art to be printed several times
on boot and login.
When start-stop-daemon(8) daemonizes a process, it closes stdout and
stderr (which is technically the whole point of daemons) but that leaves
us and users with no way to see bmcd's output. Since it is the most
important daemon on the system, enable seeing its output and to do so,
upgrade start-stop-daemon from lean busybox version to debian's.
svenrademakers
svenrademakers previously approved these changes Aug 21, 2023
tp2bmc/package/bmcd/bmcd.mk Outdated Show resolved Hide resolved
tp2bmc/package/bmcd/S94bmcd Show resolved Hide resolved
tp2bmc/package/bmcd/bmcd.mk Outdated Show resolved Hide resolved
svenrademakers
svenrademakers previously approved these changes Aug 23, 2023
Copy link
Collaborator

@svenrademakers svenrademakers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't have the chance to test-drive this. I trust you it's working accordingly

@ruslashev ruslashev merged commit 304f3c2 into master Sep 5, 2023
1 check passed
@ruslashev ruslashev deleted the feature/hello_bmcd branch September 5, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants