Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add[#240]:CI add workflow for groovy checker #313

Closed
wants to merge 1 commit into from

Conversation

vivekvr1
Copy link
Contributor

@vivekvr1 vivekvr1 commented Oct 2, 2023

Closes: #240

Be noted that 240 is the issue ID

What is the purpose of the change

The following high-level changes were made to the groovy-check.yml file:

A new job named groovy-check was added.
The groovy-check job uses the actions/setup-java@v3 action to set up Java 11.
The groovy-check job runs the gradle groovy command to compile and check the Groovy code for errors.
A new step was added to the groovy-check job to fail the workflow if the Groovy checker finds any errors.

Benefits of the change
The benefits of this change include:

Improved code quality: The Groovy checker will help to ensure that the Groovy code is always error-free.
Reduced risk of regressions: The Groovy checker will help to identify and fix errors before they are deployed to production.
Increased confidence in the codebase: The Groovy checker will help to increase confidence in the codebase by ensuring that the Groovy code is always error-free.

@vivekvr1 vivekvr1 requested a review from tungbq as a code owner October 2, 2023 16:41
@tungbq
Copy link
Owner

tungbq commented Oct 6, 2023

Hey @vivekvr1 thank you very much for the proposal! Did you have a chance to test this change?

@vivekvr1
Copy link
Contributor Author

Hey @vivekvr1 thank you very much for the proposal! Did you have a chance to test this change?

Hi @tungbq

If you have not had a chance to test the change yet, I would be happy to help you with that. I have some time available next week, and I would be happy to run the tests.

Copy link

github-actions bot commented Jun 1, 2024

This PR is stale because it has been open for 90 days with no activity.

@github-actions github-actions bot added the stale label Jun 1, 2024
Copy link

github-actions bot commented Aug 1, 2024

This PR was closed because it has been inactive for 60 days since being marked as stale.

@github-actions github-actions bot closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: add workflow for groovy checker
2 participants