Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OmegaConf #28

Merged
merged 38 commits into from
Feb 26, 2024
Merged

OmegaConf #28

merged 38 commits into from
Feb 26, 2024

Conversation

arturtoshev
Copy link
Member

Replace simple yaml with OmegaConf and refactor the library.

gerkone and others added 14 commits February 15, 2024 17:29
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 86.91589% with 42 lines in your changes are missing coverage. Please review.

Project coverage is 83.4%. Comparing base (ee9167a) to head (c4d698a).

Files Patch % Lines
lagrangebench/runner.py 79.2% 26 Missing ⚠️
lagrangebench/train/trainer.py 84.5% 11 Missing ⚠️
lagrangebench/data/data.py 80.0% 2 Missing ⚠️
lagrangebench/evaluate/rollout.py 83.3% 2 Missing ⚠️
lagrangebench/models/painn.py 50.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #28      +/-   ##
========================================
+ Coverage   69.4%   83.4%   +13.9%     
========================================
  Files         25      26       +1     
  Lines       1662    1875     +213     
========================================
+ Hits        1155    1565     +410     
+ Misses       507     310     -197     
Flag Coverage Δ
unittests 83.4% <86.9%> (+13.9%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines -43 to +55
loss_weight: LossConfig,
loss_weight: Dict[str, float],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small thing but don't think this is the case. The LossConfig dataclass is passed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still relevant?

lagrangebench/defaults.py Outdated Show resolved Hide resolved
main.py Outdated Show resolved Hide resolved
lagrangebench/defaults.py Outdated Show resolved Hide resolved
Copy link
Member

@gerkone gerkone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will follow up on LossConfig, and some minor typing/library usability changes

lagrangebench/__init__.py Outdated Show resolved Hide resolved
gerkone and others added 6 commits February 24, 2024 11:26
@arturtoshev arturtoshev merged commit 5f653c4 into main Feb 26, 2024
6 checks passed
@arturtoshev arturtoshev deleted the new-yaml branch February 26, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants