-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OmegaConf #28
OmegaConf #28
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
========================================
+ Coverage 69.4% 83.4% +13.9%
========================================
Files 25 26 +1
Lines 1662 1875 +213
========================================
+ Hits 1155 1565 +410
+ Misses 507 310 -197
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
loss_weight: LossConfig, | ||
loss_weight: Dict[str, float], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small thing but don't think this is the case. The LossConfig
dataclass is passed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still relevant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will follow up on LossConfig
, and some minor typing/library usability changes
Replace simple yaml with OmegaConf and refactor the library.