Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feauture additions #17

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Feauture additions #17

wants to merge 16 commits into from

Conversation

alf45tar
Copy link

@alf45tar alf45tar commented Jan 14, 2018

I suggest to add DigitalCC and AnalogResponsive to the main library.

@alf45tar alf45tar closed this Jan 14, 2018
@alf45tar alf45tar changed the title Add files via upload Added DigitalCC as suggested in the tttapa wiki Jan 14, 2018
@alf45tar alf45tar reopened this Jan 14, 2018
@alf45tar
Copy link
Author

alf45tar commented Feb 3, 2018

AnalogResponsiveRead library can be found here

https://github.com/dxinteractive/ResponsiveAnalogRead

or downloaded via Library Manager inside Arduino IDE

@alf45tar alf45tar changed the title Added DigitalCC as suggested in the tttapa wiki Feauture additions Feb 8, 2018
@cferrarini
Copy link

Hello,
I modified and added some features to Digital CC as Toggle (class DigitalCCT) for momentary switch toggle on/off, with optional on/off LED. Also a Class for Program Change (Class DigitalPC) for sending single program change commands, the button release command is commented in the case someone wants to send different a PC command when button is released. Also MIDI_Controller.h had to be changed to add this classes.
I want to modify bank class to include to the bank type options besides change_address and change_channel also, Change Between CC and PC, So when the bank switches, it changes between CC and PC.
I don´t know how to open a pull request and don´t want to mess, please submit my contributions.
Thanks, Celso.

Sketch ex:
DigitalPC switchespc[] = {
{9, 0, 1},
{8, 1, 1},
{7, 2, 1},
{6, 3, 1},
{5, 4, 1},
};

DigitalCT switchesct[] = {
{9, 4, 20, 1},
{8, 3, 21, 1},
{7, 2, 22, 1},
{6, 0, 23, 1},
{5, 1, 24, 1},
};

bank5.add(switchesct, Bank::CHANGE_ADDRESS);
bank5.add(switchespc, Bank::CHANGE_ADDRESS);

Digital_cc_ct.zip

@tttapa
Copy link
Owner

tttapa commented Jul 26, 2018

alf45tar, cferrarini,

Thank you for your contributions.
Many of the features you added made it into my development branch eventually, in one way or another. For example, DigitalCC and DigitalCCLatching will be supported in the next release, you can use Selectors for PC, and there is no more need for the AnalogReadResponsive library, because I've improved the filtering significantly.

What kind of use cases do you have in mind for switching between CC and PC? My idea is that you decide which one to use at the time you write the code, make your MIDI mappings based on this decision, and don't change it at run-time.

Pieter

@cferrarini
Copy link

cferrarini commented Jul 26, 2018

Hello Pieter,
I´m developing a guitar pedal control, for amplitube and guitar rig, and intend it to be minimalistic, so maybe it will only have 6 momentary switches and one momentary bank selector. This bank selector will change the buttons between PC and CC. Maybe one extra bank selector button or a third push can change addresses. There is no need of sending notes in this case.
PC will load the amp preset, and CC will toggle individual pedal settings inside each preset. Thats how the program works. So, once you have loaded the amp with PC you need CC to activate or deactivate pedals.
Your present version does not support digital CC Toggle for momentary buttons, (the one I´ve sent).
Can I use an arduino Nano 3.0 with this library? the programming process is the same as Pro Micro?

Thanks
Celso

@alf45tar
Copy link
Author

May I suggest to have a look here
https://github.com/alf45tar/Pedalino?
Everything you are looking for are there and more.

@cferrarini
Copy link

cferrarini commented Jul 26, 2018

Nice. Definetely Taking a look at it!
My pedal, is almost done, I just need to make a a bank switch between cc and pc. Im also making a wah/volume expression pedal using ir leds.

@tttapa
Copy link
Owner

tttapa commented Jul 27, 2018

The Arduino Nano would not be a good choice if you need MIDI over USB.

This Wiki page compares different boards: https://github.com/tttapa/MIDI_controller/wiki/MIDI-over-USB

@cferrarini
Copy link

Any idea to making a switch or bank button between PC and CC? The pc library Iwrote is working...

@Erikovitch
Copy link

Is there any way to use this library with motorized faders or can you add this functionality?

@tttapa
Copy link
Owner

tttapa commented Jan 29, 2019

Currently, there is no support for it.
I am working on it though, but I haven't been able to build it into the library.

I should have some free time the following weeks, when I get to it, you can expect updates in tttapa/Control-Surface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants