Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm(deps): bump inquirer from 9.3.6 to 10.1.8 #208

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 23, 2024

Bumps inquirer from 9.3.6 to 10.1.8.

Release notes

Sourced from inquirer's releases.

[email protected]

  • Fix broken backward compatibility issues with v9. Choice objects without value should default to use name as the value. Note: Please don't rely on this weird behaviour, but we fixed it since it was an unintended breaking change.

[email protected]

  • Adds the new { type: 'search' } prompt.

[email protected]

  • Fix: Re-added missing short on select and checkbox prompt.
  • Fix: Remove type requiring a close method on prompt class instances (it wasn't required.)

[email protected]

  • Re-implemented with Typescript.
  • Adding CJS support (now inquirer is publishes a dual-build CJS/ESM.)
  • All core prompts are now coming from @inquirer/prompt.
  • Custom prompts now should be implemented with @inquirer/core. Custom prompts built on [email protected] will keep working, but should plan a migration.
  • inquirer.ui.BottomBar is deleted.

My expectation is that this release should be a drop-in replacement for people using inquirer.prompt() and built-ins 🤞🏻. Please open an issue on Github if you run into issues migrating; it's a large rewrite and there might be a few sharp edges to cut! Hope you'll like this new release.

Commits
  • 273b16e Publish
  • 87b58aa Fix(@​inquirer/core): End output stream on exit (instead of destroy) (#1499)
  • 04323b3 Fix(@​inquirer/core): Destroy output stream on exit. (#1499)
  • 9c98d0e Chore(deps-dev): Bump eslint-plugin-n from 17.10.1 to 17.10.2 (#1500)
  • 056e26a Publish
  • 3a7efb2 Chore(dev-deps) Bump
  • 4513828 Fix(@​inquirer/core) Improve rendering performance (#1498)
  • 8abfcd9 Chore(dev) Add post-checkout hook
  • fa4c3b9 Chore(dev-deps) Bump to yarn 4.4.0
  • bf127a7 Chore(dev-deps) Bump typescript-eslint to v8 (#1496)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from ttsukagoshi as a code owner August 23, 2024 07:58
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Aug 23, 2024
Copy link

github-actions bot commented Aug 23, 2024

Coverage report

Caution

Coverage does not meet threshold
Statements coverage not met for global: expected >=100%, but got 41.51925078043705%

St.
Category Percentage Covered / Total
🔴 Statements
41.52% (-58.48% 🔻)
399/961
🟢 Branches
93.88% (-6.12% 🔻)
46/49
🟡 Functions
65% (-35% 🔻)
13/20
🔴 Lines
41.52% (-58.48% 🔻)
399/961
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / convert.ts
0% (-100% 🔻)
0% (-100% 🔻)
0% (-100% 🔻)
0% (-100% 🔻)
🔴
... / init.ts
0% (-100% 🔻)
0% (-100% 🔻)
0% (-100% 🔻)
0% (-100% 🔻)
🟢 src/messages.ts
92.42% (-7.58% 🔻)
100%
20% (-80% 🔻)
92.42% (-7.58% 🔻)
🔴 src/utils.ts
0% (-100% 🔻)
0% (-100% 🔻)
0% (-100% 🔻)
0% (-100% 🔻)

Test suite run failed

Failed tests: 0/27. Failed suites: 3/9.
  ● Test suite failed to run

    src/utils.ts:5:20 - error TS2614: Module '"inquirer"' has no exported member 'QuestionCollection'. Did you mean to use 'import QuestionCollection from "inquirer"' instead?

    5 import inquirer, { QuestionCollection } from 'inquirer';
                         ~~~~~~~~~~~~~~~~~~


  ● Test suite failed to run

    src/utils.ts:5:20 - error TS2614: Module '"inquirer"' has no exported member 'QuestionCollection'. Did you mean to use 'import QuestionCollection from "inquirer"' instead?

    5 import inquirer, { QuestionCollection } from 'inquirer';
                         ~~~~~~~~~~~~~~~~~~


  ● Test suite failed to run

    src/commands/init.ts:33:46 - error TS2769: No overload matches this call.
      The last overload gave the following error.
        Argument of type '{ name: string; type: string; message: string; default: boolean; }[]' is not assignable to parameter of type 'Readonly<DistributiveMerge<NumberConfig | InputConfig | { message: string; choices: readonly (Separator | Choice<unknown>)[]; pageSize?: number | undefined; loop?: boolean | undefined; default?: unknown; theme?: { ...; } | undefined; } | ... 5 more ... | EditorConfig, { ...; }>>'.

     33     const overwrite = (await inquirer.prompt([
                                                     ~
     34       {
        ~~~~~~~
    ... 
     39       },
        ~~~~~~~~
     40     ])) as InquirerInitOverwriteResponse;
        ~~~~~

      node_modules/inquirer/dist/cjs/types/index.d.ts:41:9
        41         <const A extends Answers, PrefilledAnswers extends Answers = object>(questions: Question<A>, answers?: PrefilledAnswers): PromptReturnType<PrefilledAnswers & A>;
                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        The last overload is declared here.

Report generated by 🧪jest coverage report action from 5c92451

Bumps [inquirer](https://github.com/SBoudrias/Inquirer.js) from 9.3.6 to 10.1.8.
- [Release notes](https://github.com/SBoudrias/Inquirer.js/releases)
- [Commits](https://github.com/SBoudrias/Inquirer.js/compare/[email protected]@10.1.8)

---
updated-dependencies:
- dependency-name: inquirer
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/main/inquirer-10.1.8 branch from 0ce05c9 to 5c92451 Compare August 23, 2024 18:41
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 1, 2024

Superseded by #225.

@dependabot dependabot bot closed this Oct 1, 2024
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/main/inquirer-10.1.8 branch October 1, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant