skip parsing really long log messages

tstack · Nov 20, 2024 · 512a8b7 · 512a8b7
1 parent 99dafd5
commit 512a8b7
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/src/log_data_helper.cc b/src/log_data_helper.cc
@@ -74,7 +74,7 @@ log_data_helper::parse_line(content_line_t line, bool allow_middle)
         this->ldh_line_attrs.clear();
     } else {
         auto format = this->ldh_file->get_format();
-        struct line_range body;
+        line_range body;
         auto& sa = this->ldh_line_attrs;
 
         this->ldh_line_attrs.clear();
@@ -98,7 +98,9 @@ log_data_helper::parse_line(content_line_t line, bool allow_middle)
             = std::make_unique<data_parser>(this->ldh_scanner.get());
         this->ldh_msg_format.clear();
         this->ldh_parser->dp_msg_format = &this->ldh_msg_format;
-        this->ldh_parser->parse();
+        if (body.length() < 128 * 1024) {
+            this->ldh_parser->parse();
+        }
         this->ldh_namer
             = std::make_unique<column_namer>(column_namer::language::SQL);
         this->ldh_extra_json.clear();

diff --git a/src/logfile_sub_source.cc b/src/logfile_sub_source.cc
@@ -2712,8 +2712,12 @@ logfile_sub_source::text_crumbs_for_line(int line,
         if (this->lss_token_meta_line != file_line_number
             || this->lss_token_meta_size != sf.length())
         {
-            this->lss_token_meta = lnav::document::discover_structure(
-                al, body_opt.value().saw_string_attr->sa_range);
+            if (body_opt->saw_string_attr->sa_range.length() < 128 * 1024) {
+                this->lss_token_meta = lnav::document::discover_structure(
+                    al, body_opt.value().saw_string_attr->sa_range);
+            } else {
+                this->lss_token_meta = lnav::document::metadata{};
+            }
             this->lss_token_meta_line = file_line_number;
             this->lss_token_meta_size = sf.length();
         }