add Ukrainian translation #354
Conversation
|
Also, there are a few issues I've found on a real device. |
Codecov Report
@@ Coverage Diff @@
## master #354 +/- ##
===========================================
- Coverage 86.88% 50.49% -36.39%
===========================================
Files 30 30
Lines 1617 1602 -15
Branches 178 161 -17
===========================================
- Hits 1405 809 -596
- Misses 114 758 +644
+ Partials 98 35 -63
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Hey @JekRock, thank you for taking the time to create this PR. I found 2 issues, please take a look at them.
Regarding the concerns that you pointed out:
Also, there are a few issues I've found on a real device. Here the text is too long to fit and it's not scrollable.
You can rephrase the text to be shorter. User will tend to skip very long texts in the intro slides. The original intent of the message was to explain what the time slider does.
Here and on the previous screenshot, the "skip" and "done" buttons aren't translated for some reason. They aren't present in the resources list though.
These are provided by the AppIntro library. You can create a PR in their repository to provide Ukrainian translations. See this.
| @@ -0,0 +1 @@ | |||
| Розслабтесь, покращить фокус та збільште продуктивність з мінімальним фоновим шумом | |||
There was a problem hiding this comment.
The short description needs to be <= 80 characters. Can you rephrase it to be at least 3 characters shorter?
There was a problem hiding this comment.
Sure, I'll rephrase the description to make it fit the 80 characters limitation
| <string name="water_stream">Потік води</string> | ||
| <string name="white_noise">Білий шум</string> | ||
| <string name="wind_in_palm_trees">Вітер у пальмах</string> | ||
| <string name="wind_in_chimes_of_shells">Китайський дзвіночок із мушель</string> |
There was a problem hiding this comment.
I am not sure if this is accurate. Google translates it to Chinese bell with shells.
Visual description: https://images.app.goo.gl/yiFc1eDhhXdn4DHj9
There was a problem hiding this comment.
It was the most difficult to translate.
If I understand it correctly, it's the sound made by something that looks similar to that
There is no short name for that thing in Ukrainian and the closest description is what I put into translation.
Russian translation has the word "Фурин" (link) that means "Japanese bell" (I don't agree with that translation).
I can change it to "Дзвін мушель" (bell of shells) if you think that it's a better translation for that.
There was a problem hiding this comment.
@JekRock Can we make it Bells of glass shells?
There was a problem hiding this comment.
I'm not sure that it sounds like glass shells (I may be wrong).
But generally, yes, it's kind of similar to what you suggested.
There was a problem hiding this comment.
Yeah right. More like metal shells. Bell of shells is fine I guess!
Got it, I'll rephrase it
Thanks, I'll send them a PR with translation |
|
Also, I can help with updating the Russian translation, if you don't mind |
|
@JekRock Thanks for the quick response.
Yes, please. Translations are lagging behind by a lot. |
Sure, I'll send a PR after we finish with the Ukrainian translation |
|
Also, do you have a template for the featureGraphic? |
|
@JekRock I don't have a template. I create it at canva.com using a natural image for background. The dimensions must be 1024x500. |
Rephrase the timer description to fit it to the screen
|
@ashutoshgngwr I've made changes that we've discussed. |
|
I would appriciate if you could add the "hacktoberfest-accepted" label to the PR before merging. If not, that's fine, no worries |
|
@JekRock I've added the Hacktoberfest topic to the repository so I don't think it'll be necessary but I'll add it anyways. |
|
@ashutoshgngwr Thank you! |
Changes
Add Ukrainian translation
Testing
Others