Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare release 0.2.1 #13

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Prepare release 0.2.1 #13

merged 2 commits into from
Jun 21, 2024

Conversation

sosthene-nitrokey
Copy link
Collaborator

No description provided.

robin-nitrokey
robin-nitrokey reviewed Jun 21, 2024
View reviewed changes
Copy link
Member

@robin-nitrokey robin-nitrokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we release anyway, we should replace the expect calls in lib.rs with explicit panic! or error! calls so that the messages are optimized out. I can crate a PR for that, or you can just do it in this PR.

@sosthene-nitrokey
Replace unwrap and expect calls with unwrap_or_else(|| panic!())
abf464e 
This allows the error message to be optimized out
@sosthene-nitrokey
Copy link
Collaborator Author

Done in abf464e

robin-nitrokey
robin-nitrokey approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@robin-nitrokey robin-nitrokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sosthene-nitrokey sosthene-nitrokey merged commit 655eca3 into main Jun 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robin-nitrokey robin-nitrokey robin-nitrokey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sosthene-nitrokey @robin-nitrokey