Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usize value from Error::SerializeBufferFull #22

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

robin-nitrokey
Copy link
Member

The value is not used (and actually does not provide much insight) but bloats the error enum – just removing it yields a ~ 5k binary size increase on nitrokey-3-firmware.

The value is not used (and actually does not provide much insight) but
bloats the error enum – just removing it yields a ~ 5k binary size
increase on nitrokey-3-firmware.
@sosthene-nitrokey
Copy link
Contributor

Technically a breaking change, but IMHO it's fine to release a 0.5.1 with this.

@robin-nitrokey robin-nitrokey merged commit bd92517 into main Oct 24, 2024
1 check passed
@robin-nitrokey robin-nitrokey deleted the error-usize branch October 24, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants