This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
POC for getting fetch-and-compile functioning in the browser #5760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eggplantzzz
commented
Dec 6, 2022
| userSpecification && | ||
| (fs.existsSync(userSpecification) || path.isAbsolute(userSpecification)); | ||
| let useSpecifiedLocal: boolean | string | undefined; | ||
| if (!userSpecification) { |
There was a problem hiding this comment.
There should be a better way to do this; currently this hack is here just to prevent disk access.
There was a problem hiding this comment.
For now I changed this to just check for window.
…re-organize VersionRange strategy
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a POC for getting fetch-and-compile working in the browser. The webpack configs created for this are kind of hacky with all the ridiculous shimming and a very narrow code path is attempted to avoid using the filesystem.
The biggest challenge was getting compile-solidity working in the browser. I wanted to leverage the CompilerSupplier infrastructure. I added a
loadSoljsonmethod and it was necessary to create a WebWorker in which to complete compilation as the browser would complain about not being able to use some of the web assembly api in the main thread. We pass the WebWorker the soljson and execute the compilation there before passing the result back to the main thread.