NAS-132397 / 24.10.2 / XOAUTH2 support for Outlook SMTP
#15062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
time 8:00 |
bugclerk
changed the title
XOAUTH2 support for Outlook SMTPXOAUTH2 support for Outlook SMTP
yocalebo
reviewed
Dec 2, 2024
| @@ -441,7 +440,7 @@ def send_mail_queue(self): | |||
| for queue in list(mq.queue): | |||
There was a problem hiding this comment.
I'm just making a comment here and not asking it to be changed in this PR, but we should consider changing _get_smtp_server to a context manager and use the with SMTP** context manager so we actually release resources properly in event of tracebacks.
There was a problem hiding this comment.
I'll do it in 25.04 after we merge and backport this
yocalebo
approved these changes
Dec 2, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.