Skip to content

Commit

Permalink
fix(common): no name, no namespace? Trash! (#28385)
Browse files Browse the repository at this point in the history
**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
⚒️ Fixes  # <!--(issue)-->

**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [ ] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->

**📃 Notes:**
<!-- Please enter any other relevant information here -->

**✔️ Checklist:**

- [ ] ⚖️ My code follows the style guidelines of this project
- [ ] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [ ] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [ ] ⬆️ I increased versions for any altered app according to semantic
versioning
- [ ] I made sure the title starts with `feat(chart-name):`,
`fix(chart-name):` or `chore(chart-name):`

**➕ App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._

---------

Signed-off-by: Kjeld Schouten <[email protected]>
  • Loading branch information
PrivatePuffin authored Oct 26, 2024
1 parent 87f86d8 commit 6c1a4d6
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
2 changes: 1 addition & 1 deletion charts/library/common/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,4 +48,4 @@ sources:
- https://hub.docker.com/r/mikefarah/yq
- https://hub.docker.com/r/traefik/whoami
type: library
version: 25.1.2
version: 25.1.3
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,12 @@

{{/* Parse look-ed up middlewares */}}
{{- range $m := $lookupMiddlewares -}}
{{- $name := $m.metadata.name -}}
{{- $namespace := $m.metadata.namespace -}}
{{/* Create a smaller list with only the data we want */}}
{{- $parsedMiddlewares = mustAppend $parsedMiddlewares (dict "name" $name "namespace" $namespace) -}}
{{ if and $m.metadata.name $m.metadata.namespace -}}
{{- $name := $m.metadata.name -}}
{{- $namespace := $m.metadata.namespace -}}
{{/* Create a smaller list with only the data we want */}}
{{- $parsedMiddlewares = mustAppend $parsedMiddlewares (dict "name" $name "namespace" $namespace) -}}
{{- end -}}
{{- end -}}
{{- end -}}

Expand Down

0 comments on commit 6c1a4d6

Please sign in to comment.