Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tprd 287 update openssh client for triton trtllm containers #7455

Merged
merged 8 commits into from
Jul 19, 2024
Merged

Tprd 287 update openssh client for triton trtllm containers #7455

merged 8 commits into from
Jul 19, 2024

Conversation

pvijayakrish
Copy link
Contributor

@pvijayakrish pvijayakrish commented Jul 19, 2024 •
edited
Loading

What does the PR do?

Update the openssh-client package in Triton TRTLLM containers.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

Where should the reviewer start?

Test plan:

  • CI Pipeline ID:

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

krishung5
krishung5 reviewed Jul 19, 2024
View reviewed changes
Copy link
Contributor

@krishung5 krishung5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm! Can you please resolve the conflicts as well?

build.py Outdated Show resolved Hide resolved
@pvijayakrish pvijayakrish merged commit e98aec3 into r24.07 Jul 19, 2024
3 checks passed
@pvijayakrish pvijayakrish deleted the TPRD-287-update-openssh-client-for-trtllm branch July 19, 2024 18:43
pvijayakrish added a commit that referenced this pull request Jul 23, 2024
@pvijayakrish
Tprd 287 update openssh client for triton trtllm containers (#7455)
64768a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishung5 krishung5 krishung5 approved these changes

@mc-nv mc-nv mc-nv approved these changes

@nv-kmcgill53 nv-kmcgill53 nv-kmcgill53 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pvijayakrish @krishung5 @mc-nv @nv-kmcgill53