Fix issue 12823 (EditPanel#sortUnitsToRemove) illegal argument exception #12829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UnitAttachment.java - set lombok @getter annotation for boolean attributes of pattern is* and can* having simple getters, i.e., get-methods just returning the attribute value affected by renaming methods: -AbstractPlaceDelegate.java -AirBattle.java -AiUtils.java -BattleStepsTest.java -CasualtyUtil.java -DummyPlayerTest.java -EndTurnDelegate.java -FiringGroupSplitterAaTest.java -FiringGroupSplitterGeneralTest.java -GameParserTest.java -InitializationDelegate.java -MarkNoMovementLeftTest.java -Matches.java -MovePerformer.java -MoveValidator.java -NeighborGetter.java -OffensiveGeneralRetreatTest.java -ProCombatMoveAi.java -ProNonCombatMoveAi.java -ProPurchaseOption.java -ProPurchaseOptionMap.java -ProSortMoveOptionsUtils.java -ProTechAi.java -RemoveUnprotectedUnitsTest.java -ScrambleLogic.java -StrategicBombingRaidBattle.java -TabbedProductionPanel.java -TransportTracker.java -UnitAbilityFactory.java -UnitAttachment.java -UnitAttachmentTest.java -UnitComparator.java -UnitImageFactory.java -UnitInformation.java -UnitSeparator.java -UnitTypeComparator.java -UnitTypeComparatorTest.java -WeakAi.java
EditPanel.java - avoid in method getRemovableUnitsOrder check on only one unit whether it is a transport capacity - make attributes transient - change selectedUnits.removeAll(units) to units.forEach(selectedUnits::remove) - extract method getScrollPane UnitAttachment.java - new method isTransportCapacity() replacing != -1 comparisons - comment typos
frigoref
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue 12823 (2.5.22294: EditPanel#sortUnitsToRemove:931 - java.lang.IllegalArgumentException)
Notes to Reviewer