Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opt_getUnitTypes #1 (optimize collecting unit types via streams) #12784

Merged
merged 1 commit into from
Jul 27, 2024
Merged

opt_getUnitTypes #1 (optimize collecting unit types via streams) #12784

merged 1 commit into from
Jul 27, 2024

Conversation

frigoref
Copy link
Member

PlayerUnitsPanel.java

  • optimize collecting unit types via streams
  • add documentation

Notes to Reviewer

@frigoref
opt_getUnitTypes #1
b272db6 
PlayerUnitsPanel.java
- break up logic in method getAllUnitCategories into separate methods
- add documentation
@frigoref frigoref merged commit 6a82921 into triplea-game:master Jul 27, 2024
1 check passed
@TheDog-GH
Copy link
Contributor

TheDog-GH commented Jul 27, 2024 •
edited
Loading

@frigoref
No, still the same, no German Infantry participating.

Just noticed the Air-Transport is carrying the Inf-Trained, hope that helps?

@frigoref
Copy link
Member Author

@TheDog-GH I assume you are referring to your comment on issue 12783 which would need additional information for me to be able to address whatever you have found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frigoref @TheDog-GH