Consolidate Dependencies & Cleanup #12780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DanVanAtta |
|
Thanks, that implies some new dependencies were added. I can spot a few now that probably can be removed. |
|
@TheDog-GH latest is back to 65MB 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1) Move all non-project dependencies to the top level 'build.gradle'. Now that we essentially only package the game-client, it makes sense to have one place for all dependencies. One place is simpler, easier to manage & avoids redundancy. We also get a more concrete list of everything that we will be including in the final build, rather than having to inspect every sub-project.
(2) Simplify, now that lobby is in its own repository a number of dependencies are no longer needed (EG: JDBI for database connectivity).