Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: simplify headless chat appender #12742

Merged
merged 6 commits into from
Jul 21, 2024
Merged

Refactor: simplify headless chat appender #12742

merged 6 commits into from
Jul 21, 2024

Commits on Jul 21, 2024

  1. Start with new method signature for attaching chat

    @DanVanAtta
    DanVanAtta committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    061d0e9 View commit details
    Browse the repository at this point in the history

  2. Move method

    @DanVanAtta
    DanVanAtta committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    bba1667 View commit details
    Browse the repository at this point in the history

  3. Formatting & minimize constructor visibility

    @DanVanAtta
    DanVanAtta committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    a7af901 View commit details
    Browse the repository at this point in the history

  4. Inline method

    @DanVanAtta
    DanVanAtta committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    a5b9a13 View commit details
    Browse the repository at this point in the history

  5. Simplify, use "Stream.of" instead of "List.of(..).stream()"

    @DanVanAtta
    DanVanAtta committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    b044ec4 View commit details
    Browse the repository at this point in the history

  6. Formatting

    @DanVanAtta
    DanVanAtta committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    4a0337a View commit details
    Browse the repository at this point in the history