Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bots: Replace chat upload to lobby with simple info logging #12741

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

DanVanAtta
Copy link
Member

This will have the effect of removing the bot-game chat history from moderator toolbox.

Benefits: fixes potential infinite loop that would crash the bot & otherwise simplifies the code.

Fix details:

  • Any warn/error message is sent as a chat message. Any chat message in turn is sent to the lobby. If there is an error sending a message to the lobby, it can yield an error message, which in turn triggers a chat message, which in turn yields another upload to the lobby thereby starting an infinite cycle. If we do not send messages to the lobby, then this is no longer a problem.

Future plans:

  • Overall, ideally we can invest efforts in "network relay" rather than bot hosts, and remove all of the headless-game code entirely.
  • Give moderators read-only access to the bot logs, which do contain the chat logs. (To do this, we'd need to set up a syslog "log-aggregation-server", send syslog data to that server, then run NGINX and mount the aggregated log data folder to be served as a webpage. Do a DNS entry, and set up a password & share that password with moderators).

Commentary:
  - Drawback: bot chat history will no longer be readily available
    to moderators. That was useful when deciding "he-said-she-said"
    style disputes.
  - Benefits: fixes potential infinite loop that would crash
    the bot & simplifies.

Fix details:
  - Any warn/error message is sent as a chat message. Any
    chat message in turn is sent to the lobby. If there is
    an error sending a message to the lobby, it can yield
    an error message, which in turn triggers a chat message,
    which in turn yields another upload to the lobby thereby
    starting an infinite cycle.
    If we do not send messages up to the lobby, then this is
    no longer a problem.

Future plans:
  - Overall, ideally we can invest efforts in "network relay"
    rather than bot hosts, and remove all of the headless-game
    code entirely.
@DanVanAtta DanVanAtta merged commit dcda979 into master Jul 21, 2024
1 check passed
@DanVanAtta DanVanAtta deleted the chat-upload branch July 21, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant