Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logic for damage units selection for 3hp units. #12685

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Fix logic for damage units selection for 3hp units. #12685

merged 2 commits into from
Jul 4, 2024

Commits on Jul 4, 2024

  1. Fix logic for damage units selection for 3hp units. 

    Previously logic was not working correctly and was overriding the user's selection in terms of how many units should take 2hp of damage vs. 1hp.

Adds a test. Also improves/adds some comments on the existing logic.
Fixes: triplea-game#12672
    @asvitkine
    asvitkine committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    144c098 View commit details
    Browse the repository at this point in the history

  2. Improve comments.

    @asvitkine
    asvitkine committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    0b76221 View commit details
    Browse the repository at this point in the history