Show up to 2 decimals for percents in battle calc. #11978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, but what are exactly the Run Count intervals for having 0, 1 and 2 decimals, and do they differ between dice and LL? |
|
I tested out these new settings some, and now I tend to think that 2 decimals are too much and a bit distracting when running at 10,000 or even 20,000 simulations: I would limit to 1 decimal. 2 decimals would be good for running at 100,000 thereabout though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary & Additional Notes
The extra precision is only shown when significant (which may require a different sim count than the default of 200).
As requested here: #11962
Release Note
NEW|Up to two decimal digits after the decimal point are now shown for percentages in the battle calculator.