Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logic for choosing default players in battle calc. #11924

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Improve logic for choosing default players in battle calc. #11924

merged 3 commits into from
Aug 31, 2023

Commits on Aug 30, 2023

  1. Improve logic for choosing players in battle calc. 

    This attempts to address some regressions from 2.5 where in a number of cases, the chosen sides did not correspond to what the user likely wanted. See triplea-game#11664 for details.

Some additional tests are added, while others are updated to clarify their intentions and in some cases, provide updated expectations.
    @asvitkine
    asvitkine committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    c79d000 View commit details
    Browse the repository at this point in the history

  2. Remove unneeded logic.

    @asvitkine
    asvitkine committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    9ad2014 View commit details
    Browse the repository at this point in the history

  3. Another test.

    @asvitkine
    asvitkine committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    867f92d View commit details
    Browse the repository at this point in the history