Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CollectionUtils guarantee mutable return value. #11832

Merged
merged 3 commits into from
Jul 29, 2023
Merged

Make CollectionUtils guarantee mutable return value. #11832

merged 3 commits into from
Jul 29, 2023

Commits on Jul 29, 2023

  1. Make CollectionUtils guarantee mutable return value. 

    Previously, they used Collectors.toList() which did not provide any such guarantee in its API docs, but behind-the-scenes was implemented as returning a mutable collection.

As such, there's likely triplea code that depends on that implementation detail. This change makes that implementation detail an API guarantee.

Also cleans up a couple code places that were copying the result and a few other clean ups.
    @asvitkine
    asvitkine committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    f921092 View commit details
    Browse the repository at this point in the history

  2. Spotless.

    @asvitkine
    asvitkine committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    ef28cd7 View commit details
    Browse the repository at this point in the history

  3. More spotless.

    @asvitkine
    asvitkine committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    0d2502d View commit details
    Browse the repository at this point in the history