Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix battle calc current player selection in history mode. #11803

Merged
merged 1 commit into from
Jul 22, 2023
Merged

Fix battle calc current player selection in history mode. #11803

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions game-app/game-core/src/main/java/games/strategy/engine/history/History.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,9 +179,13 @@ public synchronized void removeAllHistoryAfterNode(final HistoryNode removeAfter
if (node instanceof Step) {
player = ((Step) node).getPlayerId();
}
int nodeChangeIndex = getNextChange(node);
if (seekingEnabled && nodeChangeIndex > nextChangeIndex) {
break;
if (node.isLeaf()) {
// Don't do this logic on non-leaf nodes as getNextChange() will return
// the next change after this non-leaf, skipping all the child nodes.
int nodeChangeIndex = getNextChange(node);
if (seekingEnabled && nodeChangeIndex > nextChangeIndex) {
break;
}
}
}
return player;
Expand Down