Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ArrayIndexOutOfBoundsException in CommentPanel. #11786

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Fix ArrayIndexOutOfBoundsException in CommentPanel. #11786

merged 1 commit into from
Jul 17, 2023

Commits on Jul 17, 2023

  1. Fix ArrayIndexOutOfBoundsException in CommentPanel. 

    This a follow-up to my change that narrowed the scope of the lock in this code. We're now seeing node.getLastChild() throw an index out of bounds, even though it's directly after a size check. This is likely due to a race.

Instead of reading the children off the actual history tree, this changes the code to instead get this info directly from the event, which is more correct as well. It should fix the issue.
    @asvitkine
    asvitkine committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    3c76988 View commit details
    Browse the repository at this point in the history