Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue a cause of "Could not find step name" (2.6 bug). #11773

Merged
merged 11 commits into from
Jul 15, 2023

Commits on Jul 12, 2023

  1. Fix issue a cause of "Could not find step name".

    This was happening because the code to generate step names was not excluding units that would not participate in combat, resulting in infrastructure units getting their own steps (which later did not match what the engine generated once the filtering took place).
    
    Uses the same logic as what's done for the battle to exclude units.
    
    Fixes: triplea-game#10647
    asvitkine committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    9a5b74d View commit details
    Browse the repository at this point in the history
  2. Update mock expectations.

    asvitkine committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    a2d3fb2 View commit details
    Browse the repository at this point in the history
  3. More test fixes.

    asvitkine committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    8c78dda View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. Remove imports.

    asvitkine committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    ed2618e View commit details
    Browse the repository at this point in the history
  2. Fix existing tests.

    asvitkine committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    d964d64 View commit details
    Browse the repository at this point in the history
  3. Fix formatting.

    asvitkine committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    3366181 View commit details
    Browse the repository at this point in the history
  4. More test fixing.

    asvitkine committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    8ac3a17 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. Configuration menu
    Copy the full SHA
    61544cb View commit details
    Browse the repository at this point in the history
  2. More formatting.

    asvitkine committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    ad5e6ce View commit details
    Browse the repository at this point in the history
  3. Add a test for the fix.

    asvitkine committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    da5435a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    49eeb41 View commit details
    Browse the repository at this point in the history